Code Review for il-3373

Prepared by:Igor Kozhukhov <ikozhukhov@gmail.com> on 2013-Sep-05 23:02 +0400 MSK
Workspace:/myshare/builds/dilos-illumos-gate/dig-merge (at 716e239c4542)}
Compare against: ssh://hg@bitbucket.org/dilos/dilos-illumos-gate (at c02fb9c8a47c)
Summary of changes: 131 lines changed: 90 ins; 12 del; 29 mod; 40394 unchg
Patch of changes: il-3373.patch
Printable review: il-3373.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/fmadm/common/faulty.c

3373 gcc >= 4.5 concerns about offsetof()
4 lines changed: 4 ins; 0 del; 0 mod; 1866 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/modules/ii/ii.c

3373 gcc >= 4.5 concerns about offsetof()
5 lines changed: 4 ins; 0 del; 1 mod; 426 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/modules/libumem/misc.h

3373 gcc >= 4.5 concerns about offsetof()
6 lines changed: 4 ins; 2 del; 0 mod; 65 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/pools/poolstat/poolstat.c

3373 gcc >= 4.5 concerns about offsetof()
4 lines changed: 4 ins; 0 del; 0 mod; 1025 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/stat/common/acquire_iodevs.c

3373 gcc >= 4.5 concerns about offsetof()
5 lines changed: 4 ins; 0 del; 1 mod; 1125 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/nvpair/nvpair.c

3373 gcc >= 4.5 concerns about offsetof()
4 lines changed: 4 ins; 0 del; 0 mod; 3297 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/iso/stddef_iso.h

3373 gcc >= 4.5 concerns about offsetof()
7 lines changed: 4 ins; 2 del; 1 mod; 95 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libumem/common/misc.h

3373 gcc >= 4.5 concerns about offsetof()
6 lines changed: 4 ins; 2 del; 0 mod; 139 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/lvm/libmeta/common/meta_statconcise.c

3373 gcc >= 4.5 concerns about offsetof()
6 lines changed: 4 ins; 2 del; 0 mod; 1890 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/stand/lib/sa/stddef.h

3373 gcc >= 4.5 concerns about offsetof()
7 lines changed: 4 ins; 2 del; 1 mod; 49 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/avs/ns/rdc/rdc.c

3373 gcc >= 4.5 concerns about offsetof()
5 lines changed: 4 ins; 0 del; 1 mod; 1114 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/avs/ns/rdc/rdc_io.c

3373 gcc >= 4.5 concerns about offsetof()
5 lines changed: 4 ins; 0 del; 1 mod; 6723 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/avs/ns/sv/sv.c

3373 gcc >= 4.5 concerns about offsetof()
5 lines changed: 4 ins; 0 del; 1 mod; 2819 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/vscan/vscan_svc.c

3373 gcc >= 4.5 concerns about offsetof()
5 lines changed: 4 ins; 0 del; 1 mod; 1366 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/ecppvar.h

3373 gcc >= 4.5 concerns about offsetof()
6 lines changed: 4 ins; 2 del; 0 mod; 520 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/ib/clients/of/sol_ofs/sol_cma.h

3373 gcc >= 4.5 concerns about offsetof()
5 lines changed: 4 ins; 0 del; 1 mod; 376 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/sysmacros.h

3373 gcc >= 4.5 concerns about offsetof()
4 lines changed: 4 ins; 0 del; 0 mod; 386 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/usb/clients/audio/usb_ac/usb_ac.h

3373 gcc >= 4.5 concerns about offsetof()
4 lines changed: 4 ins; 0 del; 0 mod; 369 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/usb/clients/video/usbvc/usbvc_var.h

3373 gcc >= 4.5 concerns about offsetof()
4 lines changed: 4 ins; 0 del; 0 mod; 392 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/uwb/uwba/uwba.h

3373 gcc >= 4.5 concerns about offsetof()
4 lines changed: 4 ins; 0 del; 0 mod; 343 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/xen/io/xnb.c

3373 update files for xen
3 lines changed: 0 ins; 0 del; 3 mod; 2072 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/xen/io/xnb.h

3373 update files for xen
3 lines changed: 1 ins; 0 del; 2 mod; 213 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/xen/io/xnf.c

3373 update files for xen
12 lines changed: 1 ins; 0 del; 11 mod; 2748 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/xen/io/xnf.h

3373 update files for xen
2 lines changed: 0 ins; 0 del; 2 mod; 181 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun/io/scsi/adapters/sf.c

3373 gcc >= 4.5 concerns about offsetof()
5 lines changed: 4 ins; 0 del; 1 mod; 7237 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/io/rmclomv.c

3373 gcc >= 4.5 concerns about offsetof()
5 lines changed: 4 ins; 0 del; 1 mod; 3558 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.